Skip to content

fix: pin version for version for dev install when Trust downgrade is noticed#2644

Open
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:fix-override
Open

fix: pin version for version for dev install when Trust downgrade is noticed#2644
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:fix-override

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

@gameroman gameroman commented Apr 27, 2026 •
edited
Loading

Closes #2643

Before

image

After

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment May 2, 2026 3:09pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview May 2, 2026 3:09pm
npmx-lunaria Ignored Ignored May 2, 2026 3:09pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026 •
edited
Loading

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d5097206-d636-45f0-bcf2-b39bc5313485

📥 Commits

Reviewing files that changed from the base of the PR and between 11413c1 and d2f0c64.

📒 Files selected for processing (1)
  • app/components/Terminal/Install.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Terminal/Install.vue
📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Dev install command generation now respects an install version override so displayed commands reflect the selected version.
    • Clipboard copy corrected so copied dev install commands match the overridden/version chosen by the user.

Walkthrough

The Terminal Install component now uses installVersionOverride when non-null as the version value for building dev install command parts and for copying the dev install command, replacing the previous unconditional use of requestedVersion.

Changes

Version preference logic

Layer / File(s) Summary
Core logic
app/components/Terminal/Install.vue		 getDevInstallPartsForPM now passes version: installVersionOverride ?? requestedVersion into getInstallCommandParts.
Copy / UI wiring
app/components/Terminal/Install.vue		 copyDevInstallCommand now calls getInstallCommand with version: installVersionOverride ?? requestedVersion so copied commands respect the override.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: pinning version for dev install when Trust downgrade is noticed, which directly matches the code modification in Install.vue.
Description check ✅ Passed The description is related to the changeset, showing before/after screenshots that demonstrate the fix resolving the version mismatch issue between standard and dev installations.
Linked Issues check ✅ Passed The code changes directly address the linked issue #2643 by modifying the install version logic to respect installVersionOverride in both getDevInstallPartsForPM and copyDevInstallCommand, ensuring dev installations are pinned to the same version as standard installations.
Out of Scope Changes check ✅ Passed All changes in the pull request are scoped to the specific objective: fixing version pinning for dev installations when Trust downgrade is detected, with no unrelated modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gameroman gameroman changed the title fix: override for dev fix: pin version for version for dev install when Trust downgrade is noticed Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Terminal/Install.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: when Trust downgrade is noticed, the install version is not pinned for dev install

1 participant

@gameroman